romseygeek opened a new pull request #1461: URL: https://github.com/apache/lucene-solr/pull/1461
The grouping module tests currently all try and test both grouping by term and grouping by ValueSource. They are quite difficult to follow, however, and it is not at all easy to add tests for a new grouping type. This commit adds a new BaseGroupSelectorTestCase class which can be extended to test particular GroupSelector implementations, and adds tests for TermGroupSelector and ValueSourceGroupSelector. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
