tflobbe commented on pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#issuecomment-619239862
> Does minExactHits need to accept longs since the number of hits across shards might exceed Integer.MAX_VALUE? Good point, I didn't think about the distributed aspect yet. However, does it make sense to you? Any number > Integer.MAX_VALUE means that each shard will reply with accurate count, right? so the sum of them all will also be accurate. > Also I see you chose to make BMW an opt-in, I hope we'll find ways to enable it by default eventually. :) Yes, I think this should be default in master. I was planning in making it in another PR to make it explicit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
