[
https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085941#comment-17085941
]
Erick Erickson commented on LUCENE-7788:
----------------------------------------
[~cpoerschke] I'll have a push to the Apache repo today or tomorrow, all
precommit/check/tests run, but I want to go through the changes with fresh
eyes, I'm always suspicious of whether I've managed to mess up lots of small
changes like this.
So the gradle intergration will be part of this push, as will the first three
directories. _However_, the logging validation is not turned on by default,
it's only invoked as part of the explicit target.
I think in the near future, I _will_ turn on the validation by default as part
of check/precommit, for "cleaned" directories, plus whatever has been specified
as srcDir. Eventually that'll switch to project-based rather than
directory-based and default to everything.
As far as the new Object[] bits are concerned, this is why I'm going with
checks for anything except simple know-good patterns. I suspect (but haven't
tested) that that idiom will create a new object for any call, regardless of
whether it's logged or not which is what I want to avoid.
As far as debug and trace... Well, those are often the most verbose, but info
is, by far, the most common so I want to include that level too on the theory
that people specifying WARN level are trying to squeeze every last bit of
performance out possible.
Oh, and feel free to add/modify the help text, I don't consider it complete it
just reflects my current understanding.
> fail precommit on unparameterised log messages and examine for wasted
> work/objects
> ----------------------------------------------------------------------------------
>
> Key: LUCENE-7788
> URL: https://issues.apache.org/jira/browse/LUCENE-7788
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: LUCENE-7788.patch, LUCENE-7788.patch, gradle_only.patch,
> gradle_only.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> SOLR-10415 would be removing existing unparameterised log.trace messages use
> and once that is in place then this ticket's one-line change would be for
> 'ant precommit' to reject any future unparameterised log.trace message use.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
