[
https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085867#comment-17085867
]
Christine Poerschke commented on LUCENE-7788:
---------------------------------------------
For trace and debug logging the checks would seem to be most valuable.
I like the idea of selectively incrementally enabling file paths for the checks.
The {{help/validateLogCalls.txt}} content is very educational, thanks! I wonder
if parameterized logging plus new Object[] is common enough (or too obscure) to
have a mention there too – e.g.
[https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.5.1/solr/core/src/java/org/apache/solr/cloud/ZkController.java#L533]
– i.e. if the list of parameters is "too long" for {{a, b, c, ... x, y, z}}
listing then new Object[]\{ a, b, c, ... x, y, z } is a possibility and
"foo"\+a\+...\+"bar"\+z String concatenation is not the only choice?
> fail precommit on unparameterised log messages and examine for wasted
> work/objects
> ----------------------------------------------------------------------------------
>
> Key: LUCENE-7788
> URL: https://issues.apache.org/jira/browse/LUCENE-7788
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: LUCENE-7788.patch, LUCENE-7788.patch, gradle_only.patch,
> gradle_only.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> SOLR-10415 would be removing existing unparameterised log.trace messages use
> and once that is in place then this ticket's one-line change would be for
> 'ant precommit' to reject any future unparameterised log.trace message use.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
