[ 
https://issues.apache.org/jira/browse/LUCENE-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083401#comment-17083401
 ] 

Lucene/Solr QA commented on LUCENE-9323:
----------------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  0m 20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | 
{color:green}  0m 20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  0m 20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
15s{color} | {color:green} replicator in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}  2m 38s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-9323 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12999872/LUCENE-9323-01.patch |
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  
validatesourcepatterns  |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / ceeb55c7f5c |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
|  Test Results | 
https://builds.apache.org/job/PreCommit-LUCENE-Build/262/testReport/ |
| modules | C: lucene/replicator U: lucene/replicator |
| Console output | 
https://builds.apache.org/job/PreCommit-LUCENE-Build/262/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Fix or suppress 13 resource leak precommit warnings in lucene/replicator
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-9323
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9323
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Andras Salamon
>            Priority: Minor
>         Attachments: LUCENE-9323-01.patch
>
>
> There are 13 resource leak precommit warnings in org/apache/lucene/replicator:
> {noformat}
>  [ecj-lint] 1. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/ReplicatorTestCase.java
>  (at line 102) [ecj-lint] 1. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/ReplicatorTestCase.java
>  (at line 102) [ecj-lint]  ServerConnector c = new ServerConnector(server, 
> new SslConnectionFactory(sslcontext, "http/1.1"), [ecj-lint]                  
> ^ [ecj-lint] Resource leak: 'c' is never closed-- [ecj-lint] 2. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/ReplicatorTestCase.java
>  (at line 106) [ecj-lint]  ServerConnector c = new ServerConnector(server, 
> new HttpConnectionFactory()); [ecj-lint]                  ^ [ecj-lint] 
> Resource leak: 'c' is never closed-- [ecj-lint] 3. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
>  (at line 221) [ecj-lint]  LineFileDocs docs = new LineFileDocs(random()); 
> [ecj-lint]               ^^^^ [ecj-lint] Resource leak: 'docs' is never 
> closed-- [ecj-lint] 4. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
>  (at line 291) [ecj-lint]  LineFileDocs docs = new LineFileDocs(random()); 
> [ecj-lint]               ^^^^ [ecj-lint] Resource leak: 'docs' is never 
> closed-- [ecj-lint] 5. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
>  (at line 341) [ecj-lint]  LineFileDocs docs = new LineFileDocs(random()); 
> [ecj-lint]               ^^^^ [ecj-lint] Resource leak: 'docs' is never 
> closed-- [ecj-lint] 6. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
>  (at line 387) [ecj-lint]  LineFileDocs docs = new LineFileDocs(random()); 
> [ecj-lint]               ^^^^ [ecj-lint] Resource leak: 'docs' is never 
> closed-- [ecj-lint] 7. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
>  (at line 430) [ecj-lint]  LineFileDocs docs = new LineFileDocs(random()); 
> [ecj-lint]               ^^^^ [ecj-lint] Resource leak: 'docs' is never 
> closed-- [ecj-lint] 8. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
>  (at line 495) [ecj-lint]  LineFileDocs docs = new LineFileDocs(random()); 
> [ecj-lint]               ^^^^ [ecj-lint] Resource leak: 'docs' is never 
> closed-- [ecj-lint] 9. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
>  (at line 539) [ecj-lint]  LineFileDocs docs = new LineFileDocs(random()); 
> [ecj-lint]               ^^^^ [ecj-lint] Resource leak: 'docs' is never 
> closed-- [ecj-lint] 10. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
>  (at line 665) [ecj-lint]  LineFileDocs docs = new LineFileDocs(random()); 
> [ecj-lint]               ^^^^ [ecj-lint] Resource leak: 'docs' is never 
> closed-- [ecj-lint] 11. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
>  (at line 720) [ecj-lint]  LineFileDocs docs = new LineFileDocs(random()); 
> [ecj-lint]               ^^^^ [ecj-lint] Resource leak: 'docs' is never 
> closed-- [ecj-lint] 12. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
>  (at line 785) [ecj-lint]  LineFileDocs docs = new LineFileDocs(random()); 
> [ecj-lint]               ^^^^ [ecj-lint] Resource leak: 'docs' is never 
> closed-- [ecj-lint] 13. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java
>  (at line 1062) [ecj-lint]  LineFileDocs docs = new LineFileDocs(random()); 
> [ecj-lint]               ^^^^ [ecj-lint] Resource leak: 'docs' is never 
> closed {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to