[
https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082744#comment-17082744
]
Erick Erickson commented on LUCENE-7788:
----------------------------------------
Good idea. I'm still refining it a bit as I see different cases, so I'll work
through another directory or two before adding it in later this week.
I've been fretting a bit about keeping regressions from creeping in, cause
there are "only" 1,800 more calls that are flagged so far and it'll take a
while to work through them all. So it'll be nice to selectively enable the
check to keep that from happening.
And, if anyone wants to work on it, we can partition the work.
[~uschindler] To my surprise, there are several places that Lucene uses a
logger, which surprised me. Are they OK? I was originally thinking of
restricting to the solr tree to cut down a little on the time it took, but
maybe not? the program takes an extra couple of seconds to go through both the
Lucene and Solr trees .vs. just the Solr tree, so perhaps it's not worth
worrying about and going through them all is the right thing to do.
lucene/luke/models/documents
lucene/analysis/smartcn/src/java/org/apache/lucene/analysis/cn/smart/hhmm
lucene/spatial-extras/src/test/org/apache/lucene/spatial/prefix
> fail precommit on unparameterised log.trace messages
> ----------------------------------------------------
>
> Key: LUCENE-7788
> URL: https://issues.apache.org/jira/browse/LUCENE-7788
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: LUCENE-7788.patch, LUCENE-7788.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> SOLR-10415 would be removing existing unparameterised log.trace messages use
> and once that is in place then this ticket's one-line change would be for
> 'ant precommit' to reject any future unparameterised log.trace message use.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
