[
https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081600#comment-17081600
]
Erick Erickson commented on LUCENE-7788:
----------------------------------------
I just attached a PR, you may have to expand the issue links above, but here it
is so it's easy to see.
[https://github.com/apache/lucene-solr/pull/1425]
It's a bit ugly frankly. Constructs like: ((currentI % sliceCount) + 1) are
flagged as function calls due to the parens and the + sign.
Even in cases where you surround the call with an "if (log.isInfoEnabled)....",
you still have to add the //verified ok (I changed the verbiage, I think I'll
change it even further to just //verified).
Anyway, I'm done pending consensus, I wanted to see what it looked like to
change a directory and chose
*solr/test-framework/src/java/org/apache/solr/cloud* arbitrarily. Gives us
something concrete to talk about.
> fail precommit on unparameterised log.trace messages
> ----------------------------------------------------
>
> Key: LUCENE-7788
> URL: https://issues.apache.org/jira/browse/LUCENE-7788
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: LUCENE-7788.patch, LUCENE-7788.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> SOLR-10415 would be removing existing unparameterised log.trace messages use
> and once that is in place then this ticket's one-line change would be for
> 'ant precommit' to reject any future unparameterised log.trace message use.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
