msokolov commented on a change in pull request #1351: LUCENE-9280: Collectors
to skip noncompetitive documents
URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r396127831
##########
File path: lucene/core/src/java/org/apache/lucene/search/FieldComparator.java
##########
@@ -928,4 +928,9 @@ public int compareTop(int doc) throws IOException {
@Override
public void setScorer(Scorable scorer) {}
}
+
+ public static abstract class IteratorSupplierComparator<T> extends
FieldComparator<T> implements LeafFieldComparator {
+ abstract DocIdSetIterator iterator();
+ abstract void updateIterator() throws IOException;
Review comment:
The name seems to indicate that this is something that compares
IteratorSuppliers, when in fact it is something that is a comparator that also
supplies iterators. I'm not sure I understand yet where it fits, but given
that, a better name might be IterableComparator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
