mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash
computation optional and resilient
URL: https://github.com/apache/lucene-solr/pull/1359#discussion_r394707461
##########
File path:
solr/core/src/java/org/apache/solr/store/blob/metadata/ServerSideMetadata.java
##########
@@ -229,13 +232,18 @@ public String getDirectoryHash() {
/**
* Returns <code>true</code> if the contents of the directory passed into
this method is identical to the contents of
* the directory of the Solr core of this instance, taken at instance
creation time. If the directory hash was not
- * computed at the instance creation time, then this returns
<code>false</code>
+ * computed at the instance creation time, then we throw an
IllegalStateException indicating a programming error.
*
* Passing in the Directory (expected to be the directory of the same core
used during construction) because it seems
* safer than trying to get it again here...
+ *
+ * @throw IllegalStateException is this instance was not created with a
computed directoryHash
Review comment:
typo is=if?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
