mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash
computation optional and resilient
URL: https://github.com/apache/lucene-solr/pull/1359#discussion_r394591134
##########
File path:
solr/core/src/java/org/apache/solr/store/blob/process/CorePullTask.java
##########
@@ -286,7 +286,7 @@ void pullCoreFromBlob(boolean isLeaderPulling) throws
InterruptedException {
}
// Get local metadata + resolve with blob metadata. Given we're doing a
pull, don't need to reserve commit point
- ServerSideMetadata serverMetadata = new
ServerSideMetadata(pullCoreInfo.getCoreName(), storeManager.getCoreContainer(),
false);
+ ServerSideMetadata serverMetadata = new
ServerSideMetadata(pullCoreInfo.getCoreName(), storeManager.getCoreContainer(),
false, true);
Review comment:
Maybe add a short comment explaining the passed value of captureDirHash.
Same comment for BlobStoreUtils.java and CorePusher.java.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
