[ 
https://issues.apache.org/jira/browse/LUCENE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059939#comment-17059939
 ] 

David Smiley commented on LUCENE-8103:
--------------------------------------

Thanks for looking Munendra!  Whoops; I should have looked more carefully at 
that.  I will revert that piece immediately.  I think this issue should simply 
be an optimization and not a semantic/behavior change as well.  Not that I 
disagree with the change but it shouldn't be lumped together.

> QueryValueSource should use TwoPhaseIterator
> --------------------------------------------
>
>                 Key: LUCENE-8103
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8103
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/other
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 8.6
>
>         Attachments: LUCENE-8103.patch, LUCENE-8103.patch
>
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> QueryValueSource (in "queries" module) is a ValueSource representation of a 
> Query; the score is the value.  It ought to try to use a TwoPhaseIterator 
> from the query if it can be offered. This will prevent possibly expensive 
> advancing beyond documents that we aren't interested in.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to