[
https://issues.apache.org/jira/browse/LUCENE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059753#comment-17059753
]
Michele Palmia commented on LUCENE-8103:
----------------------------------------
I purposefully made that change to {{objectValue(doc)}} because the former
implementation seemed problematic, since it arbitrarily returned {{null}}
instead of the default value. I guess I should have been more clear about that
with [~dsmiley], not sure whether he agreed with my fix or he overlooked it. So
definitely thanks for bringing this up!
I don't fully understand the comment you linked though, so I'll try to study
that issue later. I hope David will have a more constructive answer :)
> QueryValueSource should use TwoPhaseIterator
> --------------------------------------------
>
> Key: LUCENE-8103
> URL: https://issues.apache.org/jira/browse/LUCENE-8103
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/other
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 8.6
>
> Attachments: LUCENE-8103.patch, LUCENE-8103.patch
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> QueryValueSource (in "queries" module) is a ValueSource representation of a
> Query; the score is the value. It ought to try to use a TwoPhaseIterator
> from the query if it can be offered. This will prevent possibly expensive
> advancing beyond documents that we aren't interested in.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
