[ https://issues.apache.org/jira/browse/LUCENE-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054062#comment-17054062 ]
Tomoko Uchida commented on LUCENE-9259: --------------------------------------- Since the old option {{keepShortTerm}} was added accidentally, we may be able to go further for the master branch (9.0 release). I attachedĀ [^LUCENE-9259-master.patch] to completely remove the wrongly named option and replace it with the correct one, {{preserveOriginal,}} in accordance with its Javadoc. If there is no objection, I will commit it to the master after waiting a few more days. > NGramFilter use wrong argument name for preserve option > ------------------------------------------------------- > > Key: LUCENE-9259 > URL: https://issues.apache.org/jira/browse/LUCENE-9259 > Project: Lucene - Core > Issue Type: Bug > Components: modules/analysis > Affects Versions: 7.4, 8.0 > Reporter: Paul Pazderski > Priority: Minor > Attachments: LUCENE-9259-master.patch, LUCENE-9259.patch > > > LUCENE-7960 added the possibility to preserve the original term when using > NGram filters. The documentation says to enable it with 'preserveOriginal' > and it works for EdgeNGram filter. But NGram filter requires the initial > planned option 'keepShortTerms' to enable this feature. > This inconsistency is confusing. I'll provide a patch with a possible fix. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org