[ https://issues.apache.org/jira/browse/LUCENE-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050255#comment-17050255 ]
Lucene/Solr QA commented on LUCENE-9259: ---------------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate ref guide {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 46s{color} | {color:green} common in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 7m 30s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | LUCENE-9259 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12995465/LUCENE-9259.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns validaterefguide | | uname | Linux lucene2-us-west.apache.org 4.4.0-170-generic #199-Ubuntu SMP Thu Nov 14 01:45:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / bc6fa3b | | ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 | | Default Java | LTS | | Test Results | https://builds.apache.org/job/PreCommit-LUCENE-Build/254/testReport/ | | modules | C: lucene/analysis/common solr/solr-ref-guide U: . | | Console output | https://builds.apache.org/job/PreCommit-LUCENE-Build/254/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > NGramFilter use wrong argument name for preserve option > ------------------------------------------------------- > > Key: LUCENE-9259 > URL: https://issues.apache.org/jira/browse/LUCENE-9259 > Project: Lucene - Core > Issue Type: Bug > Components: modules/analysis > Affects Versions: 7.4, 8.0 > Reporter: Paul Pazderski > Priority: Minor > Attachments: LUCENE-9259.patch > > > LUCENE-7960 added the possibility to preserve the original term when using > NGram filters. The documentation says to enable it with 'preserveOriginal' > and it works for EdgeNGram filter. But NGram filter requires the initial > planned option 'keepShortTerms' to enable this feature. > This inconsistency is confusing. I'll provide a patch with a possible fix. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org