dsmiley commented on a change in pull request #1303: LUCENE-9114: Improve
ValueSourceScorer's Default Cost Implementation
URL: https://github.com/apache/lucene-solr/pull/1303#discussion_r387660244
##########
File path:
lucene/queries/src/java/org/apache/lucene/queries/function/ValueSourceScorer.java
##########
@@ -94,4 +97,17 @@ public float getMaxScore(int upTo) throws IOException {
return Float.POSITIVE_INFINITY;
}
+ /**
+ * Cost evaluation function which defines the cost of access for the
TwoPhaseIterator for this class
+ * This method should be overridden for specifying custom cost methods. Used
by {@link TwoPhaseIterator#matchCost()}
+ * for the instance owned by this class
+ *
+ * @return cost of access
+ *
+ * @lucene.experimental
+ */
+ protected float costEvaluationFunction() {
Review comment:
Can we call this simply matchCost now since, after all, the TPI.matchCost
just calls it now with no mutable override?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
