dsmiley commented on a change in pull request #1303: LUCENE-9114: Improve
ValueSourceScorer's Default Cost Implementation
URL: https://github.com/apache/lucene-solr/pull/1303#discussion_r387436290
##########
File path:
lucene/queries/src/java/org/apache/lucene/queries/function/ValueSourceScorer.java
##########
@@ -39,9 +39,13 @@
* @lucene.experimental
*/
public abstract class ValueSourceScorer extends Scorer {
+ // Fixed cost for a single iteration of the TwoPhaseIterator instance
+ private static final int DEF_COST = 5;
+
protected final FunctionValues values;
private final TwoPhaseIterator twoPhaseIterator;
private final DocIdSetIterator disi;
+ private float externallyMutableCost;
Review comment:
Or we could use a Float object to more clearly show as user-settable via
non-null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
