nknize commented on a change in pull request #1290: LUCENE-9251: Filter equal
edges with different value on isEdgeFromPolygon
URL: https://github.com/apache/lucene-solr/pull/1290#discussion_r385902441
##########
File path: lucene/core/src/java/org/apache/lucene/geo/Tessellator.java
##########
@@ -915,13 +914,14 @@ private static final Node filterPoints(final Node start,
Node end) {
continueIteration = false;
nextNode = node.next;
prevNode = node.previous;
- //We can filter points when they are the same, if not and they are
co-linear we can only
- //remove it if both edges have the same value in .isNextEdgeFromPolygon
- if (isVertexEquals(node, nextNode) ||
- (prevNode.isNextEdgeFromPolygon == node.isNextEdgeFromPolygon &&
+ // we can filter points when:
+ if (isVertexEquals(node, nextNode) || // 1. they are the same,
+ // isVertexEquals(prevNode, nextNode) || // 2.- each one starts and
ends in each other
Review comment:
nit: remove comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
