andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double
rather than Double to avoid NPE
URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379399436
##########
File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java
##########
@@ -51,6 +61,18 @@ public String toString() {
", updateCount=" + updateCount +
'}';
}
+
+ public double toDouble() {
Review comment:
I don't think so, no - and I think some/all of the the other `public` things
in these classes could be made less accessible too. Happy to take a look at
this, but would like to make sure the metrics aggregation is working correctly
first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
