andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double
rather than Double to avoid NPE
URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r380230110
##########
File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java
##########
@@ -93,18 +115,11 @@ public double getMax() {
if (values.isEmpty()) {
return 0;
}
- Double res = null;
+ double res = 0;
Review comment:
I've added a (temporary) warning when negative numbers are encountered -
this immediately gave me this in the log, which indicates my assumption was
incorrect:
```
o.a.s.m.AggregateMetric negative metric value: -1.0
```
So I think I need to go back to the drawing board with this. Will review the
tests and to ensure the negative number situation is covered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
