[
https://issues.apache.org/jira/browse/SOLR-14247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033197#comment-17033197
]
Erick Erickson commented on SOLR-14247:
---------------------------------------
No failures beasting it 1,000 times. This makes me a little nervous, in that
those sleeps were put in for a reason. That said, if we run into problems, we
can go back in and put in a timer and check the condition every, say, 100 ms
rather than stick a sleep in and hope it's long enough. I usually put a timer
in that has unreasonably long upper bound (say 30 seconds) on the theory that I
don't care if the test takes a long time in the (hopefully) rare failure cases.
> IndexSizeTriggerMixedBoundsTest does a lot of sleeping
> ------------------------------------------------------
>
> Key: SOLR-14247
> URL: https://issues.apache.org/jira/browse/SOLR-14247
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Mike Drob
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When I run tests locally, the slowest reported test is always
> IndexSizeTriggerMixedBoundsTest coming in at around 2 minutes.
> I took a look at the code and discovered that at least 80s of that is all
> sleeps!
> There might need to be more synchronization and ordering added back in, but
> when I removed all of the sleeps the test still passed locally for me, so I'm
> not too sure what the point was or why we were slowing the system down so
> much.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
