mbwaheed commented on a change in pull request #1188: SOLR-14044: Support
collection and shard deletion in shared storage
URL: https://github.com/apache/lucene-solr/pull/1188#discussion_r374895375
##########
File path:
solr/core/src/java/org/apache/solr/store/blob/metadata/CorePushPull.java
##########
@@ -137,7 +139,7 @@ public BlobCoreMetadata pushToBlobStore(String
currentMetadataSuffix, String new
*/
for (BlobCoreMetadata.BlobFile d :
resolvedMetadataResult.getFilesToDelete()) {
bcmBuilder.removeFile(d);
- BlobCoreMetadata.BlobFileToDelete bftd = new
BlobCoreMetadata.BlobFileToDelete(d, System.currentTimeMillis());
+ BlobCoreMetadata.BlobFileToDelete bftd = new
BlobCoreMetadata.BlobFileToDelete(d, System.nanoTime() / 1000000);
Review comment:
Can we put this conversion in some utility and put a reason why we use
nanoTime and not currentTimeMillis?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
