mbwaheed commented on a change in pull request #1188: SOLR-14044: Support
collection and shard deletion in shared storage
URL: https://github.com/apache/lucene-solr/pull/1188#discussion_r374909544
##########
File path:
solr/core/src/java/org/apache/solr/store/blob/process/BlobDeleteManager.java
##########
@@ -71,92 +108,81 @@
* delete until we know for sure the file can be resuscitated...
*/
private final long deleteDelayMs;
+
+ private AtomicBoolean isShutdown;
/**
- * TODO : Creates a default delete client, should have config based one
+ * Creates a new BlobDeleteManager with the provided {@link
CoreStorageClient} and instantiates
+ * it with a default deletedelayMs, queue size, and thread pool size. A
default {@link BlobDeleteProcessor}
Review comment:
minor: deleteDelayMs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
