[ 
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028221#comment-17028221
 ] 

Mikhail Khludnev commented on SOLR-12325:
-----------------------------------------

Slightly tweaked, [~anatolii_siuniaev]'s patch.

Now it doesn't count segements without matches, presumably it may throw an 
error if there's no match, but I think silently refuse it's ok, and will be 
convenient for users.

{{NO_MORE_DOCS}} it's a great case! Thanks to [~munendrasn]  for reminder. Now 
it refuse to count hits behind the last matching doc (relying on block index 
constraint), and the reason is consistency. If there's a hit beyond the last 
matched doc, next time those hits might reside in a separate segment, where 
they shouldn't be counted (presumably, see above) 

Patch also includes brief ref guide.   

> introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet
> ------------------------------------------------------------------
>
>                 Key: SOLR-12325
>                 URL: https://issues.apache.org/jira/browse/SOLR-12325
>             Project: Solr
>          Issue Type: New Feature
>          Components: Facet Module
>            Reporter: Mikhail Khludnev
>            Assignee: Mikhail Khludnev
>            Priority: Major
>             Fix For: 8.5
>
>         Attachments: SOLR-12325.patch, SOLR-12325.patch, SOLR-12325.patch, 
> SOLR-12325.patch
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> It might be faster twin for {{uniqueBlock(\_root_)}}. Please utilise buildin 
> query parsing method, don't invent your own. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to