ErickErickson commented on a change in pull request #1226: LUCENE-9134 Port
ant-regenerate tasks to Gradle build
URL: https://github.com/apache/lucene-solr/pull/1226#discussion_r373097476
##########
File path: gradle/defaults-java.gradle
##########
@@ -25,13 +25,13 @@ allprojects {
tasks.withType(JavaCompile) {
options.encoding = "UTF-8"
options.compilerArgs += [
- "-Xlint",
+ "-Xlint",
"-Xlint:-deprecation",
"-Xlint:-serial",
"-Xdoclint:all/protected",
- "-Xdoclint:-missing",
- "-Xdoclint:-accessibility",
+ "-Xdoclint:-missing",
Review comment:
Actually, the version on master has the trailing whitespace and this removes
them. I looked at my intellij settings and I have "strip trailing spaces on
Save for modified lines".
So when I commented those lines out to get some deprecation information from
compiling, they trailing whitespace was stripped.
I'd prefer to leave the trimmed whitespace in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
