mikemccand commented on a change in pull request #1155: LUCENE-8962: Add 
ability to selectively merge on commit
URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r373008935
 
 

 ##########
 File path: 
lucene/core/src/java/org/apache/lucene/index/LiveIndexWriterConfig.java
 ##########
 @@ -480,6 +488,22 @@ public String getSoftDeletesField() {
     return softDeletesField;
   }
 
+  /**
+   * Expert: return the amount of time to wait for merges returned by by 
MergePolicy.findCommitMerges(...).
+   * If this time is reached, those merges will be aborted and we will wait 
again. If this time limit is reached again,
 
 Review comment:
   This is no longer true?  We will just wrap up the commit w/ those merges 
that did finish, and let the still running merges finish to completion?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to