mikemccand commented on a change in pull request #1155: LUCENE-8962: Add 
ability to selectively merge on commit
URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r373008002
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java
 ##########
 @@ -484,6 +487,23 @@ public IndexWriterConfig setCommitOnClose(boolean 
commitOnClose) {
     return this;
   }
 
+  /**
+   * Expert: sets the amount of time to wait for merges returned by 
MergePolicy.findCommitMerges(...).
+   * If this time is reached, we proceed with the commit based on segments 
merged up to that point.
 
 Review comment:
   Maybe also say that any merges still running after this time will still run 
to completion, so they are not wasted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to