alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost 
by payload 
URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-579200844
 
 
   I followed the refactor comments from both @diegoceccarelli  and @romseygeek 
.
   The PR seems much cleaner right now both Lucene and Solr side.
   Copious tests are present and should cover the various situations.
   
   Few questions remain:
   
   - from a test I read a comment from @dsmiley  saying: "confirm 
autoGeneratePhraseQueries always builds OR queries" from 
org.apache.solr.search.TestSolrQueryParser#testSynonymQueryStyle
   
   - what can we do for the SpanBoostQuery, I was completely not aware they are 
going to be deprecated
   
   Let me know
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to