victorchenal opened a new pull request #1206: SOLR-14215: Improve SolrFeature performance when there are no filter queries URL: https://github.com/apache/lucene-solr/pull/1206 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr: * https://issues.apache.org/jira/projects/LUCENE * https://issues.apache.org/jira/projects/SOLR You will need to create an account in Jira in order to create an issue. The title of the PR should reference the Jira issue number in the form: * LUCENE-####: <short description of problem or changes> * SOLR-####: <short description of problem or changes> LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description In cases where a SolrFeature only contains a main query `q` and no filter queries `fq`, it is possible to traverse documents using the doc iterator from `q` instead of constructing one from a processed filter that combines all of the queries. In our test datasets this made retrieving the feature *10 times faster*. Specifically, the call to `getProcessedFilter` inside `getDocIdSetIteratorFromQueries` is expensive: https://github.com/apache/lucene-solr/blob/16e537db7efe37eb7519b07dc96c5026c0a1d193/solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java#L242-L243 That method aims at returning a doc iterator that traverses over the documents that match all of the criteria of `q` and `fq`. When there are no filter queries, this just returns a doc iterator for `q`. # Solution When `fq` is null or empty, use the iterator from `q` directly as it is a lot faster. # Tests Existing tests for `SolrFeature` already cover this use case, in particular `TestUserTermScoreWithQ`. # Checklist - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [x] I have run `ant precommit` and the appropriate test suite. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
