mocobeta commented on a change in pull request #1169: LUCENE-9004: A minor
feature and patch -- support deleting vector values and fix segments merging
URL: https://github.com/apache/lucene-solr/pull/1169#discussion_r366914317
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90KnnGraphWriter.java
##########
@@ -216,8 +216,11 @@ private void mergeKnnGraph(FieldInfo mergeFieldInfo,
final MergeState mergeState
int docid;
while ((docid = sub.nextDoc()) != NO_MORE_DOCS) {
int mappedDocId = docMap.get(docid);
+ /// deleted document (not alive)
+ if (mappedDocId < 0) {
Review comment:
You're right, this is needed for document deletion. A small correction: the
condition should be `mappedDocId == -1`. (According to the Javadoc of the
DocMap#get() method.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
