mocobeta commented on issue #1169: LUCENE-9004: A minor feature and patch -- support deleting vector values and fix segments merging URL: https://github.com/apache/lucene-solr/pull/1169#issuecomment-574687579 Hi @irvingzhang, > a new type of Query (KnnDelQuery) And Weight (KnnDelScoreWeight) for the dedicated deletion of exact values that only full matches the query vector; It looks like there is semantic mismatch between the functionality and naming of the new Query and Weight. The query finds the documents which have the same value to a query vector, right? I think the class names should represent their functionality instead of use cases (e.g, for deletion). > I'm not sure if I need to create a new issue or not. We don't need to create another issue (until the HNSW branch is merged into the master), let's just open pull request(s) for the HNSW branch.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
