dweiss commented on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes URL: https://github.com/apache/lucene-solr/pull/1163#issuecomment-573780909 bq. It would require duplicating the whitelist/blacklist of file types/locations in two separate formats. It doesn't have to be that general. You only want to check a few launch scripts after all. It can wait until gradle lands in - then it's literally a few lines. I've had some issues in the past with .gitattributes: third-party tools not understanding it or ignoring it, etc. Perhaps the situation has improved but a precommit check is fairly definitive: you don't rely on any external tool.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
