gerlowskija commented on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes URL: https://github.com/apache/lucene-solr/pull/1163#issuecomment-573779560 I thought about a precommit check, but discarded the idea for a few reasons. It would require duplicating the whitelist/blacklist of file types/locations in two separate formats. Which is fine if it buys us something that we don't get with `gitattributes` alone, but I'm not sure that it does. Is there a specific case that `gitattributes` would get wrong that precommit would catch for us?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
