gerlowskija commented on issue #1154: SOLR-13985: Bind to localhost interface 
by default
URL: https://github.com/apache/lucene-solr/pull/1154#issuecomment-573684995
 
 
   `solr.cmd` has the wrong line endings again.  It looks like SOLR-13977 was 
fixed and then regressed almost immediately with some other changes to the code 
there.
   
   I attempted to fix this in this PR but the diff in github was confusing and 
it was hard to be confident that I wasn't discarding other changes to solr.cmd. 
 So my revised plan is to commit this as-is, and push up a separate PR to 
change the line endings (and possibly add `.gitattributes` protection for these 
files).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to