gerlowskija opened a new pull request #1154: SOLR-13985: Bind to localhost interface by default URL: https://github.com/apache/lucene-solr/pull/1154 Prior to this commit, Solr's Jetty listened for connections on all network interfaces. This commit changes it to only listen on localhost, to prevent incautious administrators from accidentally exposing their Solr deployment to the world. Administrators who wish to override this behavior can set the SOLR_JETTY_HOST property in their Solr include file (solr.in.sh/solr.in.cmd) to "0.0.0.0" or some other value. A version of this commit was previously reverted due to inconsistency between SOLR_HOST and SOLR_JETTY_HOST. This commit fixes this issue. # Description Reinstates the bind-to-localhost functionality, which was previously reverted. Contains a fix to keep the SOLR_HOST and SOLR_JETTY_HOST properties better aligned by default. # Tests The way that our automated tests run, they don't exercise any of this functionality. So the testing for this was mostly manual. A lot of my testing was of the form: Start Solr(s) a particular way with particular settings, create a simple collection and a complex collection, index to them both, query them both, try a few other collection-admin actions, and shut everything down. I did this with a single node deploy, a multi-node deploy, the "cloud" example, a multi-node deploy with SOLR_HOST set (this took some /etc/hosts fiddling), and a multi-node deploy with some localhost-bound nodes and some public ones. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [x] I have run `ant precommit` and the appropriate test suite. - [ ] I have added tests for my changes. - [x] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
