msokolov commented on PR #16806: URL: https://github.com/apache/lucene/pull/16806#issuecomment-6577340711
Thanks, @goankur, nice work - this seems like a reasonable approach: use a fixed bit set for smaller graphs and a hashset for larger ones that will be sparser given the fixed graph fanout. It's funny that you noticed clearing the bitsets as a hotspot! My only lingering question is whether we already have such an abstraction in the Lucene code base -- I know there are places where we switch between SparseBitSet and dense FixedBitSets, but I don't think this particular combo (IntHashSet + FixedBitSet) exists? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
