goankur commented on PR #16806: URL: https://github.com/apache/lucene/pull/16806#issuecomment-6534188816
> Have you tried replacing `BitSet` with `IntHashSet`? It would be a lot less complex than this. Thanks @msokolov for the `IntHashSet` suggestion. I tried it, and it beats my first revision, so this PR now uses it and drops TrackingVisitedBitSet. On the implementation style: though the code was written by AI, I provided guidance on implementation specifics like using a `VisitedSet` interface and a simple static method that returns an implementation backed by either `FixedBitSet` or `IntHashSet`. I also provided guidance on unit tests to check each scenario where different data-structure was used. Testing done was extensive to ensure this is a genuine improvement without any regression for existing small graph scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
