vsop-479 commented on code in PR #16904:
URL: https://github.com/apache/lucene/pull/16904#discussion_r4396059930
##########
lucene/analysis/common/src/java/org/apache/lucene/collation/package-info.java:
##########
@@ -80,17 +80,20 @@
* Document doc = new Document();
* doc.add(new StoredField("tracer", tracer[i]));
* doc.add(new TextField("contents", data[i], Field.Store.NO));
+ * CollationDocValuesField dvField = new
CollationDocValuesField("contents", collator);
Review Comment:
Maybe create `CollationDocValuesField` outside the loop, and only call
`setStringValue` inside it? see `TestCollationDocValuesField#testBasic` for an
example.
##########
lucene/analysis/common/src/java/org/apache/lucene/collation/package-info.java:
##########
Review Comment:
Can we remove this? `setAnalyzeRangeTerms` was removed in
https://issues.apache.org/jira/browse/LUCENE-7355.
This call is no longer needed, since `QueryParserBase#newRangeQuery` now
normalizes the range endpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
