mikepapadim commented on PR #16855: URL: https://github.com/apache/lucene/pull/16855#issuecomment-6344729006
> +1. This only happens whenmax == `NO_MORE_DOCS` . Normally we pass`maxDoc` , but I found several call sites that pass`NO_MORE_DOCS` directly, for example `SeededKnnVectorQuery` . https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/SeededKnnVectorQuery.java#L323 > > It may also be worth exploring whether these call sites should pass`maxDoc`. Thanks for checking. From what i see is that IndexSearcher passes NO_MORE_DOCS when doing full segment searches, and DrillSidewaysScorer requires that, so the clamp fix needs to stay in the scorer. DenseConjunctionBulkScorer already clamps the same way. I checked the other bulk scorers and none of them walks windows past `maxDoc`. SeededKnnVectorQuery may hit the slow path i start investigating here. I am happy opening a follow-up issue? wdyt? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
