kkewwei commented on PR #16855: URL: https://github.com/apache/lucene/pull/16855#issuecomment-6344479001
+1. This only happens whenmax == `NO_MORE_DOCS` . Normally we pass`maxDoc` , but I found several call sites that pass`NO_MORE_DOCS` directly, for example `SeededKnnVectorQuery` . https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/SeededKnnVectorQuery.java#L323 It may also be worth exploring whether these call sites should pass`maxDoc`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
