noblepaul commented on a change in pull request #1109: More pervasive use of 
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361021437
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
 ##########
 @@ -1408,7 +1415,7 @@ private Codec initCodec(SolrConfig solrConfig, final 
IndexSchema schema) {
     final PluginInfo info = 
solrConfig.getPluginInfo(CodecFactory.class.getName());
     final CodecFactory factory;
     if (info != null) {
-      factory = resourceLoader.newInstance(info.className, CodecFactory.class);
+      factory = resourceLoader.newInstance(info, CodecFactory.class);
 
 Review comment:
   one mor eplace where reload of packages are not considered at all

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to