noblepaul commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361021282
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -890,7 +897,7 @@ private UpdateHandler createReloadedUpdateHandler(String
className, String msg,
}
private UpdateHandler createUpdateHandler(String className) {
- return createInstance(className, UpdateHandler.class, "Update Handler",
this, getResourceLoader());
+ return newInstance(new PluginInfo("updateHandler", className),
UpdateHandler.class, this, getResourceLoader());
Review comment:
Again. No thought given to how it updates, if package is updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]