bruno-roustant commented on a change in pull request #1103: LUCENE-9102: add
maxQueryLength option to DirectSpellChecker
URL: https://github.com/apache/lucene-solr/pull/1103#discussion_r360642971
##########
File path:
lucene/suggest/src/java/org/apache/lucene/search/spell/DirectSpellChecker.java
##########
@@ -195,9 +197,27 @@ public int getMinQueryLength() {
* metric.
*/
public void setMinQueryLength(int minQueryLength) {
+ if (minQueryLength > this.maxQueryLength)
Review comment:
Actually I think we don't need these checks because whatever the value for
minQueryLength and maxQueryLength, the logic is always the same, no surprise.
So personally I would remove these checks, but I'm ok to keep them, your
choice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
