bruno-roustant commented on a change in pull request #1103: LUCENE-9102 add maxQueryLength option to DirectSpellChecker URL: https://github.com/apache/lucene-solr/pull/1103#discussion_r360348014
########## File path: lucene/suggest/src/java/org/apache/lucene/search/spell/DirectSpellChecker.java ########## @@ -75,6 +75,8 @@ private float thresholdFrequency = 0f; /** minimum length of a query word to return suggestions */ private int minQueryLength = 4; + /** maximum length of a query word to return suggestions */ + private int maxQueryLength = 0; Review comment: I prefer to initialize maxQueryLength to Integer.MAX_VALUE, it's more intuitive, so that there is no special <= 0 or < min value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
