noblepaul commented on a change in pull request #1071: SOLR-14003: Refactor code to avoid reading state from Replica/Slic URL: https://github.com/apache/lucene-solr/pull/1071#discussion_r359156196
########## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/DirectShardState.java ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.client.solrj.cloud; + +import java.util.function.Predicate; + +import org.apache.solr.common.cloud.Replica; +import org.apache.solr.common.cloud.Slice; + +/**Reads the state from state.json + * + */ +public class DirectShardState implements ShardStateProvider { Review comment: >My understanding was that the purpose of introducing ShardStateProvider was to provide The single API point that is the only source of truth about the current shard/replica state (similar to other *StateProvider-s) The `state` attribute will have to go away when the old model goes away. So, if your collection is created with `externalState=true` You really have no information of the state in the `state.json`. Nobody updates it nobody reads from it. Internally we always must rely on the interface to do the right thing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
