noblepaul commented on a change in pull request #1071: SOLR-14003: Refactor code to avoid reading state from Replica/Slic URL: https://github.com/apache/lucene-solr/pull/1071#discussion_r359155516
########## File path: solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java ########## @@ -167,11 +167,15 @@ public String getNodeName() { return nodeName; } - /** Returns the {@link State} of this replica. */ + /** Returns the {@link State} of this replica. use {@link org.apache.solr.client.solrj.cloud.ShardStateProvider#getState(Replica)} instead*/ + @Deprecated public State getState() { Review comment: > the old one still prevents us from moving the state reporting out of the actual Replica object.. We can only deprecate stuff . We could possibly remove it but that should be done later (may be 9.0) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org