[
https://issues.apache.org/jira/browse/SOLR-14095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998661#comment-16998661
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14095:
------------------------------------------------------
Created a PR. Some comments:
* While I'd like to use JSON, Javabin was easier since it already supports the
object types needed. Not sure if there is a way to do that in Json without a
ton of changes.
* I added knobs for enabling unsafe serialization/deserialization. For rolling
restarts someone would have to use those, and use a multiple phase deployment
if they want to get to a safe place. Even in the case of an atomic restart of
the cluster users may need to clear the completed/failed queues from ZooKeeper
if they want to do a single phase deployment.
* I plan to remove those knobs from the code in master in a new PR, once this
is merged.
> Remove serialization and/or support serialization filtering
> -----------------------------------------------------------
>
> Key: SOLR-14095
> URL: https://issues.apache.org/jira/browse/SOLR-14095
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Robert Muir
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Removing the use of serialization is greatly preferred.
> But if serialization over the wire must really happen, then we must use JDK's
> serialization filtering capability to prevent havoc.
> https://docs.oracle.com/javase/10/core/serialization-filtering1.htm#JSCOR-GUID-3ECB288D-E5BD-4412-892F-E9BB11D4C98A
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
