[
https://issues.apache.org/jira/browse/SOLR-14100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997589#comment-16997589
]
Robert Muir commented on SOLR-14100:
------------------------------------
That comment isn't correct either. The lucene policy file is actually tighter
around properties and cleaned up.
It is annoying to clean this up: practically you have to remove the uses of
System.getProperties() [this asks for read-write * since it returns a mutable
map].
Lots of third party software is just terribly written and will do
System.getProperties().get(someKey) instead of System.getProperty(someKey). I
don't know why its so common: maybe its an IDE autocomplete issue.
Given how many dependencies solr has, I bet one or more of them are doing this,
and we'll have to fix that...
> System properties cross test suite boundary
> -------------------------------------------
>
> Key: SOLR-14100
> URL: https://issues.apache.org/jira/browse/SOLR-14100
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Major
>
> At some point in time all system properties were saved/ restored in the top
> test class. When security manager was added (a long time ago) as the default
> this has been turned off (because the rule couldn't read all properties then)
> and replaced with just a selected subset of properties to be checked (in
> LuceneTestCase). Sadly, Solr's security policy allows all properties to be
> written and I bet this also leads to complex interactions between tests.
> We can allow read access to all properties at first but all writeable/
> modifiable properties should be identified and added to a top-level restore
> rule, along with security manager policy that selectively enables them (so
> that we know they're saved and restored after each test).
> This is going to be a tedious task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
