[
https://issues.apache.org/jira/browse/SOLR-14100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997576#comment-16997576
]
Dawid Weiss commented on SOLR-14100:
------------------------------------
I think it is. I haven't noticed it myself but once upon a time this was "my"
property restore rule (from randomizedtesting) and now it's this
(LuceneTestCase):
{code}
.around(new TestRuleRestoreSystemProperties(
// Enlist all properties to which we have write access (security
manager);
// these should be restored to previous state, no matter what the
outcome of the test.
// We reset the default locale and timezone; these properties change
as a side-effect
"user.language",
"user.timezone",
// TODO: these should, ideally, be moved to Solr's base class.
"solr.directoryFactory",
"solr.solr.home",
"solr.data.dir"
))
{code}
plus this in the policy file:
{code}
// Basic permissions needed for Lucene to work:
permission java.util.PropertyPermission "*", "read,write";
{code}
> System properties cross test suite boundary
> -------------------------------------------
>
> Key: SOLR-14100
> URL: https://issues.apache.org/jira/browse/SOLR-14100
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Major
>
> At some point in time all system properties were saved/ restored in the top
> test class. When security manager was added (a long time ago) as the default
> this has been turned off (because the rule couldn't read all properties then)
> and replaced with just a selected subset of properties to be checked (in
> LuceneTestCase). Sadly, Solr's security policy allows all properties to be
> written and I bet this also leads to complex interactions between tests.
> We can allow read access to all properties at first but all writeable/
> modifiable properties should be identified and added to a top-level restore
> rule, along with security manager policy that selectively enables them (so
> that we know they're saved and restored after each test).
> This is going to be a tedious task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
