eribeiro commented on a change in pull request #1083: SOLR-13662: Fixes to
package manager
URL: https://github.com/apache/lucene-solr/pull/1083#discussion_r357946068
##########
File path:
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java
##########
@@ -121,25 +121,44 @@ public void close() throws IOException {
Map<String, SolrPackageInstance> ret = new HashMap<String,
SolrPackageInstance>();
Review comment:
nitpick: `Map<String, SolrPackageInstance> ret = new HashMap<>();`
Also, lines below could be:
```
packages.forEach( (packageName, instance) -> {
if (Strings.isNullOrEmpty(packageName) == false &&
packages.get(packageName) != null) {
ret.put(packageName, getPackageInstance(packageName, instance));
}
});
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
