eribeiro commented on a change in pull request #1083: SOLR-13662: Fixes to 
package manager
URL: https://github.com/apache/lucene-solr/pull/1083#discussion_r357945564
 
 

 ##########
 File path: 
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java
 ##########
 @@ -260,7 +288,7 @@ private boolean deployPackage(SolrPackageInstance 
packageInstance, boolean pegTo
   public boolean verify(SolrPackageInstance pkg, List<String> collections) {
 
 Review comment:
   Wouldn't be the case of inserting the statement below at line 289:
   ```
   if (collections == null || collections.isEmpty()) {
      return false;
   }

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to